Add find and find! methods to Indexable #15552
Open
+73
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
approved these changes
Mar 13, 2025
src/indexable.cr
Outdated
Comment on lines
836
to
838
| offset += size if offset < 0 | ||
| return nil if offset < 0 | ||
| return (index(offset) { |i| yield i }).try { |i| unsafe_fetch(i) } || raise Enumerable::NotFoundError.new |
There was a problem hiding this comment.
Might make sense to follow the pattern of the other ! bang methods:
Suggested change
| offset += size if offset < 0 | |
| return nil if offset < 0 | |
| return (index(offset) { |i| yield i }).try { |i| unsafe_fetch(i) } || raise Enumerable::NotFoundError.new | |
| find(offset) || raise Enumerable::NotFoundError.new |
Otherwise find! could return nil if given an invalid offset while the other methods like index! would raise.
There was a problem hiding this comment.
I'm not sure this is entirely addressed. If you do something like collection.find! -1 that'll return nil as it stands. Which we likely don't want to happen for this bang version.
NVM, I see the logic that handles that now. But the return nil still concerns me as wouldn't that make the return type T? which again makes find! no different than find?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added implementation and tests for
findandfind!in Indexable, as discussed in this issue: #14642